Support binary request/response bodies (#57)#83
Merged
codefromthecrypt merged 1 commit intoOpenFeign:masterfrom Oct 22, 2013
davidmc24:feature/binary-bodies
Merged
Support binary request/response bodies (#57)#83codefromthecrypt merged 1 commit intoOpenFeign:masterfrom davidmc24:feature/binary-bodies
codefromthecrypt merged 1 commit intoOpenFeign:masterfrom
davidmc24:feature/binary-bodies
Conversation
|
feign-pull-requests #113 SUCCESS |
Closed
Contributor
There was a problem hiding this comment.
I'd prefer to javadoc this saying that when present, you can use new String(req.body(), req.charset()) vs adding isBodyText and having 2 accessors for body
Contributor
|
looks close. I'd like to remove the suffixes of |
Contributor
Author
|
Sounds good. I'll take another pass at this tomorrow. |
Request/Response/RequestTemplate are now fundamentally based on a byte[] body field. For Request/RequestTemplate, if a charset is provided, it can be treated as text. For many users of the library, the change should barely be noticeable, as the methods that were changed were mostly used internally. There were some non-backwards-compatible signature changes that require a major version bump, however.
Contributor
Author
|
Updated based on feedback. The following changes have been made.
|
|
feign-pull-requests #116 SUCCESS |
Contributor
|
Sorry I half reviewed the update then got distracted. Lgtm and thanks for the new members of FeignTest |
codefromthecrypt
pushed a commit
that referenced
this pull request
Oct 22, 2013
Support binary request/response bodies (#57)
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Support binary request/response bodies (#57)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request/Response/RequestTemplate are now fundamentally based on a bodyData field, which is a byte[].
For Request/RequestTemplate, if a charset is provided, it can be treated as text.
If you are only using text bodies, usage of the library should feel almost exactly the same.
There were some non-backwards-compatible signature changes that require a
major version bump, however.