Separate the keda's trigger configuration from scaleOptions#232
Merged
benjaminhuo merged 1 commit intoOpenFunction:mainfrom Feb 10, 2022
Merged
Separate the keda's trigger configuration from scaleOptions#232benjaminhuo merged 1 commit intoOpenFunction:mainfrom
benjaminhuo merged 1 commit intoOpenFunction:mainfrom
Conversation
benjaminhuo
reviewed
Feb 10, 2022
Signed-off-by: laminar <[email protected]>
benjaminhuo
reviewed
Feb 10, 2022
| bootstrapServers: kafka-server-kafka-brokers.default.svc.cluster.local:9092 | ||
| consumerGroup: autoscaling-subscriber | ||
| lagThreshold: "10" | ||
| targetKind: "object" |
Member
There was a problem hiding this comment.
Is it possible to add a default value for targetKind?
default to object if not set in the yaml?
Member
Author
There was a problem hiding this comment.
I've added the default value, like this:
OpenFunction/pkg/core/serving/openfuncasync/servingrun.go
Lines 433 to 442 in 69b4c94
benjaminhuo
approved these changes
Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for issue #184
Signed-off-by: laminar [email protected]