use generate-cert.sh to generate caBundle and tls.* files#261
Merged
benjaminhuo merged 1 commit intoOpenFunction:mainfrom Mar 31, 2022
Merged
use generate-cert.sh to generate caBundle and tls.* files#261benjaminhuo merged 1 commit intoOpenFunction:mainfrom
generate-cert.sh to generate caBundle and tls.* files#261benjaminhuo merged 1 commit intoOpenFunction:mainfrom
Conversation
benjaminhuo
requested changes
Mar 31, 2022
cf4b4f2 to
5668eef
Compare
benjaminhuo
reviewed
Mar 31, 2022
Signed-off-by: laminar <[email protected]>
5668eef to
6abbf6f
Compare
benjaminhuo
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we can remove the dependency on the cert-manager. We can use
generate-cert.shto generate the information we need for the certification process.This requires us to go into the
hackdirectory and manually execute thebash generate-cert.shcommand beforemake manifests. This action will automatically replace the certification information in the relevant files.Signed-off-by: laminar [email protected]