Added the parameter validation capabilities for Function.#290
Merged
benjaminhuo merged 6 commits intoOpenFunction:mainfrom May 13, 2022
wrongerror:main
Merged
Added the parameter validation capabilities for Function.#290benjaminhuo merged 6 commits intoOpenFunction:mainfrom wrongerror:main
benjaminhuo merged 6 commits intoOpenFunction:mainfrom
wrongerror:main
Conversation
Signed-off-by: wrongerror <[email protected]>
Signed-off-by: wrongerror <[email protected]>
# Conflicts: # apis/core/v1beta1/function_webhook.go
Member
|
The |
wanjunlei
reviewed
May 12, 2022
…ants already defined in dependent components instead of defining strings to implement validation Signed-off-by: wrongerror <[email protected]>
benjaminhuo
reviewed
May 12, 2022
benjaminhuo
reviewed
May 12, 2022
… keys of map[interface{}]bool to []string
Signed-off-by: wrongerror <[email protected]>
benjaminhuo
reviewed
May 12, 2022
…s, scalers to support custom components Signed-off-by: wrongerror <[email protected]>
benjaminhuo
approved these changes
May 13, 2022
Member
|
This is a great enhancement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is to solve this issue: #274.
Now, function are validated before creating and updating, avoid wait-error-retry，in order to make the user experience more user-friendly.
Signed-off-by: wrongerror [email protected]