config eventsource handler image & trigger handler image(#353)#354
Merged
benjaminhuo merged 3 commits intoOpenFunction:mainfrom Aug 28, 2022
Merged
config eventsource handler image & trigger handler image(#353)#354benjaminhuo merged 3 commits intoOpenFunction:mainfrom
benjaminhuo merged 3 commits intoOpenFunction:mainfrom
Conversation
|
|
Member
|
@wrongerror would you help to review this? |
wrongerror
reviewed
Aug 22, 2022
controllers/events/event.go
Outdated
| return function | ||
| } | ||
|
|
||
| func getDefaultConfig(ctx context.Context, c client.Client, log logr.Logger) map[string]string { |
Member
There was a problem hiding this comment.
https://github.com/OpenFunction/OpenFunction/blob/main/controllers/core/serving_controller.go#L313
Looks like a bit of a duplicate definition, maybe it should be moved to pkg/util
wrongerror
previously approved these changes
Aug 23, 2022
…#353) Signed-off-by: shyupc <[email protected]>
…#353) Signed-off-by: shyupc <[email protected]>
benjaminhuo
reviewed
Aug 27, 2022
Signed-off-by: shyupc <[email protected]>
benjaminhuo
approved these changes
Aug 28, 2022
Member
|
@shyupc Are you in our wechat group? You can scan below barcode to get in if you're not in Also it'll be great if you can let us know how you use OpenFunction in more details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.