Skip to content

integrate wasmedge#415

Merged
benjaminhuo merged 1 commit intoOpenFunction:mainfrom
wrongerror:main
Feb 15, 2023
Merged

integrate wasmedge#415
benjaminhuo merged 1 commit intoOpenFunction:mainfrom
wrongerror:main

Conversation

@wrongerror
Copy link
Member

No description provided.

Signed-off-by: wrongerror <[email protected]>

WasmEdgeWorkloadRuntimeName = "wasmedge"
WasmEdgeRuntimeClassName = "openfunction-crun"
WasmEdgeBuildStrategyName = "wasmedge"
Copy link
Member

@benjaminhuo benjaminhuo Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add the wasmedge buildStrategy file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can also be processed by passing parameters to buildah strategy. but our fn.Spec.Build.Params donot support array values. need another pr.

  status:
    completionTime: "2023-02-15T10:14:59Z"
    conditions:
    - lastTransitionTime: "2023-02-15T10:14:59Z"
      message: 'the Build is not registered correctly, build: builder-j7x66-build-5p5f8,
        registered status: False, reason: WrongParameterValueType'
      reason: BuildRegistrationFailed
      status: "False"
      type: Succeeded

Copy link
Member

@benjaminhuo benjaminhuo Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can also be processed by passing parameters to buildah strategy. but our fn.Spec.Build.Params donot support array values. need another pr.

Another PR to do what?
Can we simply change the wasmEdgeBuildStrategyName to buildah?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build wasmedge program need this parameter:

parameters:
  - defaults:
    - annotation=module.wasm.image/variant=compat-smart
    description: The values for the args in the Dockerfile. Values must be in the
      format KEY=VALUE.
    name: build-args
    type: array

@lizzzcai
Copy link
Member

BTW, the wasmedge integration with runwasi was merged, just want to check is there a plan to support it here or do it in the future?

@benjaminhuo benjaminhuo merged commit aa106df into OpenFunction:main Feb 15, 2023
@benjaminhuo
Copy link
Member

BTW, the wasmedge integration with runwasi was merged, just want to check is there a plan to support it here or do it in the future?

Let's discuss this in tomorrow's community meeting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants