Update go builder to support declarative function api#56
Merged
benjaminhuo merged 5 commits intoOpenFunction:mainfrom May 27, 2022
Merged
Conversation
Signed-off-by: Lize Cai <[email protected]>
Signed-off-by: Lize Cai <[email protected]>
Member
|
@lizzzcai ff-go v0.2.4 released https://github.com/OpenFunction/functions-framework-go/releases/tag/v0.2.4 , would you update the builder accordingly? |
Signed-off-by: Lize Cai <[email protected]>
Member
Author
I have updated to |
benjaminhuo
reviewed
May 27, 2022
benjaminhuo
reviewed
May 27, 2022
cmd/go/of_functions_framework/converter/get_package/main_test.go
Outdated
Show resolved
Hide resolved
…verter/get_package Signed-off-by: Lize Cai <[email protected]>
benjaminhuo
reviewed
May 27, 2022
Member
Author
|
@benjaminhuo , the release note in https://github.com/OpenFunction/functions-framework-go/releases/tag/v0.3.0 is not rendered with |
benjaminhuo
reviewed
May 27, 2022
Member
Signed-off-by: Lize Cai <[email protected]>
benjaminhuo
approved these changes
May 27, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up of OpenFunction/functions-framework-go#48
build.shFail to build the stack #55Open points:
1. I increase the version tov3. as the previous one isv2. It looks like we are not following thesemantic versioning. Can we confirm the version?2. I add some tests, however, the current testing pipeline is not working with the go-ff (but we are not testing any now). As we need to export
FUNC_CONTEXTnow.To do:
1. release go-ff tov0.3.0