Conversation
Signed-off-by: wanjunlei <[email protected]>
| @@ -0,0 +1,256 @@ | |||
| package image | |||
There was a problem hiding this comment.
pkg/revision-controller/image/image.go ?
There was a problem hiding this comment.
This package includes the revision and revision controller, the image and git are revision, so revision is more suitable.
There was a problem hiding this comment.
Like Knative revision and azure container apps revisions https://learn.microsoft.com/en-us/azure/container-apps/revisions, Revision is used to specify a version of Function Serving. It's not related to how the function is built(from git or from source in image) or where the source code is from.
This repo is actually used to update revision of function serving based on git source changes or image changes. So the git and image stuff is not part of revisions, they're triggers or controllers of revisions.
Whenever the image of the function serving is updated, a new Knative revision is created and by default, all traffic is routed to the latest knative revision by default.
| @@ -0,0 +1,14 @@ | |||
| package provider | |||
There was a problem hiding this comment.
pkg/revision-controller/git/provider/interface.go ?
controllers/function_controller.go
Outdated
| return err | ||
| } | ||
|
|
||
| revisionType := config[constants.RevisionType] |
There was a problem hiding this comment.
revisionType => revisionControllerType ?
constants.RevisionType => constants.RevisionControllerType ?
There was a problem hiding this comment.
The type is the revision type, not the revision controller type, so revisionType is more acurrate.
Signed-off-by: wanjunlei <[email protected]>
Signed-off-by: wanjunlei <[email protected]>
Signed-off-by: wanjunlei <[email protected]>
Signed-off-by: wanjunlei [email protected]
The first commit.