Merged
Conversation
Shaking while at the edge of the map has been completely eliminated. In order to do this, comparison with tile height was also removed which fixed a few outlier cases. The main cause was viewport axis were only being set if it's respective isometric axis was at the boundary, instead of either isometric axis. Viewport no longer gets stuck which was related to the shaking in the end. (OpenRCT2#2875) Refactored viewport_update_position. I moved viewport_set_underground_flag above the bounds checking function since it had no relation to it. (OpenRCT2#996, OpenRCT2#2589) Scrolling on the map edge with arrow keys or mouse edge will now go the same speed in both directions. (OpenRCT2#2254) Added changelog entry.
c2e82b0 to
a719967
Compare
Contributor
|
This has been tried to be fixed a few times. Always with just as many bugs as before. Have you tested small maps, using keyboard movement keys, using mouse movement? |
Contributor
Author
|
Can confirm: Small maps work just as well. I tried 13x13. Arrow movement, dragging movement, and edge scrolling. |
Contributor
|
Can also confirm that this fixes the various issues listed above, and works with very small maps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shaking while at the edge of the map has been completely eliminated. In
order to do this, comparison with tile height was also removed which
fixed a few outlier cases.
The main cause was viewport axis were only being set if it's respective
isometric axis was at the boundary, instead of either isometric axis.
Viewport no longer gets stuck which was related to the shaking in the
end. (#996, #2589, #2875)
Refactored
viewport_update_position. I movedviewport_set_underground_flagabove the bounds checking function sinceit had no relation to it.
Scrolling on the map edge with arrow keys or mouse edge will now go the
same speed in both directions. (#2254)
Added changelog entry.