Skip to content

fix(ui): unverified user#122

Merged
smarcet merged 2 commits intomainfrom
hotfix/unverified-user
Apr 15, 2026
Merged

fix(ui): unverified user#122
smarcet merged 2 commits intomainfrom
hotfix/unverified-user

Conversation

@smarcet
Copy link
Copy Markdown
Collaborator

@smarcet smarcet commented Apr 15, 2026 •
edited by coderabbitai bot
Loading

ref: https://app.clickup.com/t/86b9envq1

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced one-time password (OTP) delivery logic during email validation to now consider both password setup status and account verification status. This prevents unnecessary OTP messages from being sent to unverified accounts lacking password setup, resulting in a more streamlined and accurate authentication experience.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 15, 2026 •
edited
Loading

Warning

Rate limit exceeded

@smarcet has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 38 minutes and 56 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 38 minutes and 56 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9a690e1e-83d1-4564-ac80-d531138b447b

📥 Commits

Reviewing files that changed from the base of the PR and between d7e893e and 8337eea.

📒 Files selected for processing (1)
  • app/Services/Auth/UserService.php
📝 Walkthrough

Walkthrough

A conditional logic change in the LoginPage's email validation callback now prevents OTP emission when the response explicitly indicates is_verified is false, even if has_password_set is falsy, adding an additional verification check to the OTP triggering condition.

Changes

Cohort / File(s) Summary
Login Email Validation Logic
resources/js/login/login.js		 Modified the condition in onValidateEmail success callback to prevent OTP emission when is_verified is explicitly false, adding a secondary check alongside the existing has_password_set evaluation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A condition most refined,
Verification checks aligned,
OTP flows won't race ahead,
When is_verified turns red,
Safer logins, cleanly designed! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix(ui): unverified user' is vague and generic, using non-descriptive terms that don't convey meaningful information about the specific change. Revise the title to be more specific about the actual change, such as 'fix(ui): prevent OTP emission for unverified users' to clearly describe what was fixed.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/unverified-user

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-122/

This page is automatically updated on each push to this PR.

@smarcet
fix(auth): null check before calling getId() in verifyEmail
8337eea 
Split combined null/inactive check into separate guards to prevent
"Call to a member function getId() on null" when no user is found
for the verification token.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-122/

This page is automatically updated on each push to this PR.

@smarcet smarcet merged commit db9f777 into main Apr 15, 2026
7 checks passed
smarcet added a commit that referenced this pull request Apr 16, 2026
@smarcet
fix(ui): unverified user (#122)
0508f60 
* fix(ui): unverified user

* fix(auth): null check before calling getId() in verifyEmail

Split combined null/inactive check into separate guards to prevent
"Call to a member function getId() on null" when no user is found
for the verification token.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@smarcet