Open
Conversation
Adopt: - odlparent-14.3.1 - infrautils-7.1.12 - yangtools-14.0.23 - mdsal-15.0.4 - controller-12.0.5 - aaa-0.22.5 - netconf-10.0.3 - bgpcep-1.0.1 JIRA: LIGHTY-428 Signed-off-by: tobias.pobocik <[email protected]>
OpenApiServiceImpl now no longer receives base path from JaxRsEndpoint but rather just as a string through JaxRsOpenApi, which makes storing JaxRsEndpoint in LightyServices pointless. see: opendaylight/netconf@99744ac#diff-bc065e5b677ea0df8f2f90804ccfed6efc8369de523bc241a13585779523555b opendaylight/netconf@064f52e JIRA: LIGHTY-428 Signed-off-by: tobias.pobocik <[email protected]>
opendaylight/netconf@45afbb4 JIRA: LIGHTY-428 Signed-off-by: tobias.pobocik <[email protected]>
opendaylight/netconf@c1b8141 JIRA: LIGHTY-428 Signed-off-by: tobias.pobocik <[email protected]>
opendaylight/netconf@3628f2e JIRA: LIGHTY-428 Signed-off-by: tobias.pobocik <[email protected]>
There was a problem hiding this comment.
Code Review
This pull request performs a significant update of OpenDaylight dependencies (e.g., odlparent 14.3.1, yangtools 14.0.23) and synchronizes various configuration files and Java source files with the updated netconf-node-topology revision (2025-12-05). It refactors the core controller by removing JaxRsEndpoint management from LightyServices and updates the Netty-based Restconf implementation to utilize newer transport configurations. A critical review comment identified that the NettyEndpointConfiguration parameters in NettyRestConf.java are likely incorrect or misordered, specifically noting that a 100-byte maxHeaderSize is too small for standard HTTP traffic and that the stream limits are set excessively high.
https://github.com/apache/maven-surefire/releases/tag/surefire-3.5.5 JIRA: LIGHTY-428 Signed-off-by: tobias.pobocik <[email protected]> (cherry picked from commit 45a89ae)
https://checkstyle.org/releasenotes.html#Release_12.2.0 https://checkstyle.org/releasenotes.html#Release_12.3.0 https://checkstyle.org/releasenotes.html#Release_12.3.1 https://checkstyle.org/releasenotes.html#Release_13.0.0 https://checkstyle.org/releasenotes.html#Release_13.1.0 https://checkstyle.org/releasenotes.html#Release_13.2.0 JIRA: LIGHTY-428 Signed-off-by: tobias.pobocik <[email protected]> (cherry picked from commit b89736d)
Odlparent bumped to newer version of jetty, making this version override redundant: opendaylight/odlparent@edb4f96 JIRA: LIGHTY-427 Signed-off-by: tobias.pobocik <[email protected]>
26c252a to
26b7d20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
odlparent-14.3.1
infrautils-7.1.12
yangtools-14.0.23
mdsal-15.0.4
controller-12.0.5
aaa-0.22.5
netconf-10.0.3
bgpcep-1.0.1