Do not override odlparent managed versions#2622
Open
Tobianas wants to merge 3 commits intoPANTHEONtech:mainfrom
Open
Do not override odlparent managed versions#2622Tobianas wants to merge 3 commits intoPANTHEONtech:mainfrom
Tobianas wants to merge 3 commits intoPANTHEONtech:mainfrom
Conversation
Make odlparent as a parent of lighty-minimal-parent to set dependency versions across the project. This also requires us to disable strict ODL checkstyle as lighty.io uses its own. JIRA: LIGHTY-427 Signed-off-by: tobias.pobocik <[email protected]>
There was a problem hiding this comment.
Code Review
This pull request integrates odlparent as a parent for lighty-minimal-parent and removes explicit versions for various dependencies and plugins across the project to rely on centralized management. However, several issues were identified where removing versions will lead to build failures, specifically for the central-publishing-maven-plugin and the maven-gpg-plugin in modules that do not inherit the necessary management. Furthermore, globally skipping static analysis plugins in the minimal parent inadvertently disables the project's own quality checks. Feedback also suggests re-incorporating the SLF4J bug pattern for SpotBugs and cleaning up now-unused version properties.
Now when lighty-minimal-parent has odlparent as its parent, there is no need to specify these versions. JIRA: LIGHTY-427 Signed-off-by: tobias.pobocik <[email protected]>
7593cd0 to
0d5500e
Compare
This version is no longer required, as it is recieved from odlparent. JIRA: LIGHTY:427 Signed-off-by: tobias.pobocik <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some dependencies we usually bump according to odlparent. Assuming they are managed by ODL we do not need to manage them in lighty.io as well.