Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PULL REQUEST TITLE: UofT-DSI | python - Assignment-1
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code to define the anagram_checker() function as well as created a test case for the is_case_sensitive version of the function.
What did you learn from the changes you have made?
I learned about string manipulation in python and case sensitivity for testing equivalence in logical statements.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I could have forced the strings to upper case instead of lower case. Seems more likely that people will type a word all in lower case, so this seemed like the most intuitive approach.
The anagram checker also does not account for whether the words are real, or if the strings contain spaces.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I think the biggest challenge for me was to figure out how to compare the contents of the string. Ended up looking at resources on stack exchange.
How were these changes tested?
I ran the anagram_checker function on all the examples and created one of my own.
A reference to a related issue in your repository (if applicable)
Checklist