Skip to content

wrote an anagram checking python function#1

Open
Ph-Duncan wants to merge 1 commit intomainfrom
assignment-1
Open

wrote an anagram checking python function#1
Ph-Duncan wants to merge 1 commit intomainfrom
assignment-1

Conversation

@Ph-Duncan
Copy link
Copy Markdown
Owner

PULL REQUEST TITLE: UofT-DSI | python - Assignment-1

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Adding code to define the anagram_checker() function as well as created a test case for the is_case_sensitive version of the function.

What did you learn from the changes you have made?

I learned about string manipulation in python and case sensitivity for testing equivalence in logical statements.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I could have forced the strings to upper case instead of lower case. Seems more likely that people will type a word all in lower case, so this seemed like the most intuitive approach.

The anagram checker also does not account for whether the words are real, or if the strings contain spaces.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

I think the biggest challenge for me was to figure out how to compare the contents of the string. Ended up looking at resources on stack exchange.

How were these changes tested?

I ran the anagram_checker function on all the examples and created one of my own.

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants