Converting pandas index takes very long, add in arrow_table.#41
Merged
justinGilmer merged 2 commits intomasterfrom Jul 24, 2023
Merged
Converting pandas index takes very long, add in arrow_table.#41justinGilmer merged 2 commits intomasterfrom
justinGilmer merged 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small regression in the arrow_to_dataframe method, trying to set the pandas index as the time column leads to pretty massive slowdowns in performance. A pandas issue, not ours. But for our use cases, we like to use pandas dataframes.
If we need to set the index, we can do that at a different point of the workflow, not when we are getting the data back from arrow. This makes the arrow method appear to be very slow when it is not.