Provide option to sort the arrow tables#47
Merged
justinGilmer merged 3 commits intomasterfrom Aug 25, 2023
Merged
Conversation
Previously, the arrow endpoints are not guaranteed to present their data in a sorted order, this PR lets the user set that for single stream calls, and sorts by time for the streamset operations by default. Streamset transformers like streamset.to_dataframe in the old version of the api used a PointBuffer that would sort the values by time before returning to the user. The single stream arrow methods now have a boolean argument `sorted` to let the user specify if they want to sort the returned table on the 'time' column or not. This is False by default. The streamset methods though, will be sorted by default and the user wont be able to switch that. We can change that later if needed.
|
This pull request has been linked to Shortcut Story #25767: Update btrdb-python arrow api to sort the tables on the |
jleifnf
reviewed
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the arrow endpoints are not guaranteed to present their data in a sorted order, this PR lets the user set that for single stream calls, and sorts by time for the streamset operations by default.
Streamset transformers like
streamset.to_dataframein the old version of the api used aPointBufferthat would sort the values by time before returning to the user.The single stream arrow methods now have a boolean argument
sortedto let the user specify if they want to sort the returned table on the'time'column or not.This is False by default.
The streamset methods though, will be sorted by default and the user wont be able to switch that. We can change that later if needed.