Conversation
Collaborator
dpanici
commented
Mar 27, 2026
- Fixes bug for NAE constraints when L>M where the full eq behavior for the given order rho would not be constrained (i.e. it would not include some of the modes, leadig to the behavior being incompletely constrained)
- Adds utility function for arbitrary order zernike -> given order rho behavior, which reduces redundant code.
Contributor
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | -0.60 % | 4.136e+03 | 4.111e+03 | -24.86 | 42.27 | 40.06 |
test_proximal_jac_w7x_with_eq_update | -0.60 % | 6.556e+03 | 6.517e+03 | -39.53 | 166.00 | 164.89 |
test_proximal_freeb_jac | 0.01 % | 1.335e+04 | 1.335e+04 | 0.78 | 90.44 | 89.66 |
test_proximal_freeb_jac_blocked | -0.16 % | 7.701e+03 | 7.689e+03 | -11.94 | 80.52 | 79.53 |
test_proximal_freeb_jac_batched | 0.43 % | 7.735e+03 | 7.768e+03 | 32.92 | 79.52 | 79.02 |
test_proximal_jac_ripple | -0.78 % | 3.656e+03 | 3.628e+03 | -28.37 | 67.51 | 68.00 |
test_proximal_jac_ripple_bounce1d | -0.99 % | 3.803e+03 | 3.765e+03 | -37.46 | 79.76 | 79.96 |
test_eq_solve | -2.91 % | 2.242e+03 | 2.177e+03 | -65.19 | 100.07 | 99.26 |For the memory plots, go to the summary of |
Collaborator
Author
|
Maybe just invert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.