Skip to content

Hemalvarambhia issue 48#58

Merged
SergeStinckwich merged 5 commits intomasterfrom
hemalvarambhia-issue-48
Jul 5, 2018
Merged

Hemalvarambhia issue 48#58
SergeStinckwich merged 5 commits intomasterfrom
hemalvarambhia-issue-48

Conversation

@SergeStinckwich
Copy link
Copy Markdown
Member

Hemal fix #48

…nions,

moved messages to the Quaternions package.
the Extensions package with the aforementioned.
@hemalvarambhia
Copy link
Copy Markdown
Contributor

hemalvarambhia commented Jul 3, 2018

@SergeStinckwich The QuaternionExtensions package has not been deleted from the file system yet. Initially, I unloaded the said package from Pharo and the tests still passed. This would indicate that we can safely delete it.

@SergeStinckwich
Copy link
Copy Markdown
Member Author

You have to modify the BaselineOfPolyMath that load the packages.

@hemalvarambhia
Copy link
Copy Markdown
Contributor

Presumeably I just remove L60 of that file: https://github.com/PolyMathOrg/PolyMath/blob/master/src/BaselineOfPolyMath/BaselineOfPolyMath.class.st

is that right?

@SergeStinckwich
Copy link
Copy Markdown
Member Author

No enough, replace two lines :

package: 'Math-Quaternion' with: [ spec requires: #('Math-Complex') ];
package: 'Math-QuaternionExtensions' with: [ spec requires: #('Math-DHB-Numerical' 'Math-Quaternion' 'Math-Polynomials') ];

with

package: 'Math-Quaternion' with: [ spec requires: #('Math-Complex' 'Math-DHB-Numerical' 'Math-Polynomials') ];

@SergeStinckwich
Copy link
Copy Markdown
Member Author

ok I merge your changes on master. Next time you should do a PR on development branch. Look at the contributing guide here: https://github.com/PolyMathOrg/PolyMath/blob/development/CONTRIBUTING.md

@SergeStinckwich SergeStinckwich merged commit d269822 into master Jul 5, 2018
@SergeStinckwich SergeStinckwich deleted the hemalvarambhia-issue-48 branch July 8, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants