added permutation package & changed baseline accordingly#66
Merged
SergeStinckwich merged 1 commit intoPolyMathOrg:developmentfrom Jul 8, 2018
Merged
added permutation package & changed baseline accordingly#66SergeStinckwich merged 1 commit intoPolyMathOrg:developmentfrom
SergeStinckwich merged 1 commit intoPolyMathOrg:developmentfrom
Conversation
Contributor
Author
|
now git asks me whether to close the pull request. i guess i should press that button. |
Member
|
Werner, I reopen the PR. You should merge the pull request to the main development branch and not close directly this PR. I think this is better that someone else than the one who create the PR, should merge. I will review your changes and then merge them if I'm find them ok. |
SergeStinckwich
approved these changes
Jul 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is this the way one does these things???
werner