Cleanup style issues in Compiler.cs#10368
Merged
iSazonov merged 14 commits intoPowerShell:masterfrom Oct 22, 2019
Merged
Conversation
00859a3 to
fa5c25c
Compare
fa5c25c to
c5f1f5a
Compare
SteveL-MSFT
requested changes
Sep 18, 2019
Member
There was a problem hiding this comment.
per https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md it seems the current style is correct? Also, I believe only public fields have Pascal Casing otherwise it would be camelCasing
Collaborator
Author
There was a problem hiding this comment.
The properties is used in other classes and files.
It seems it is bad if we see a code like follow in another file:
functionContext._scriptBlock.Ast.ExtentI believe the properties should be public in the internal class. Thoughts?
Collaborator
Author
There was a problem hiding this comment.
I removed all extra changes and refactor commits.
efe9c63 to
224256c
Compare
1344fdc to
4038e0a
Compare
4038e0a to
7b125f4
Compare
SteveL-MSFT
approved these changes
Oct 21, 2019
14 tasks
kilasuit
pushed a commit
to kilasuit/PowerShell
that referenced
this pull request
Nov 9, 2019
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix style issue in Compiler.cs file.
Please review commit by commit. There is a lot of commits but everyone is small and simple.
PR Context
CodeFactor has two nice metrics:
If we take a file with this two metrics being large there is a high probability that we will get a PR with a large number of style errors.
So make sense proactively fix style issues in such files and save a time of code reviewers later.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.