Adding PSCore group policy definitions#10468
Merged
TravisEz13 merged 14 commits intoPowerShell:masterfrom Sep 12, 2019
Merged
Conversation
iSazonov
reviewed
Sep 3, 2019
TravisEz13
reviewed
Sep 3, 2019
TravisEz13
reviewed
Sep 4, 2019
Member
|
@anmenaga I made changes. Be sure to pull changes from the branch if you need to make any more changes. |
TravisEz13
reviewed
Sep 11, 2019
TravisEz13
reviewed
Sep 11, 2019
TravisEz13
requested changes
Sep 11, 2019
Member
|
@iSazonov thanks for reviewing. |
TravisEz13
approved these changes
Sep 11, 2019
iSazonov
reviewed
Sep 12, 2019
joeyaiello
reviewed
Sep 12, 2019
joeyaiello
reviewed
Sep 12, 2019
joeyaiello
reviewed
Sep 12, 2019
joeyaiello
reviewed
Sep 12, 2019
joeyaiello
reviewed
Sep 12, 2019
joeyaiello
reviewed
Sep 12, 2019
joeyaiello
reviewed
Sep 12, 2019
Contributor
|
Added just a couple of comments/suggestions to the strings here, sorry for not doing it as a review (I was afraid of getting distracted 😄 ) |
Co-Authored-By: Joey Aiello <[email protected]>
Co-Authored-By: Joey Aiello <[email protected]>
Co-Authored-By: Joey Aiello <[email protected]>
Co-Authored-By: Joey Aiello <[email protected]>
Co-Authored-By: Joey Aiello <[email protected]>
Co-Authored-By: Joey Aiello <[email protected]>
Co-Authored-By: Joey Aiello <[email protected]>
Author
|
@joeyaiello thank you; I've updated per your suggestions. |
TravisEz13
approved these changes
Sep 12, 2019
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Group Policy tools (e.g.
gpedit.msc) use administrative template files (.admx, .adml) to populate policy settings in their user interface. This allows administrators to manage registry-based policy settings for PowerShell Core.This PR:
Policy settings Fall-Backfunctionality described in PowerShell Core Policy RFC.*) registry-based PS Core policy settings;
*)
Fall-Back to Windows PS policy settingsfunctionality.PR Context
PowerShell Core Policy RFC was recently accepted, so UX related to PowerShell Core GroupPolicy settings has to me adjusted accordingly.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.