Remove the event handler that was causing breakpoint changes to be erroneously replicated to the host runspace debugger#10503
Merged
2 commits merged intoPowerShell:masterfrom Sep 10, 2019
Conversation
iSazonov
reviewed
Sep 10, 2019
Co-Authored-By: Ilya <[email protected]>
TravisEz13
reviewed
Sep 10, 2019
| # Ensure that breakpoints were not created in the default runspace. | ||
| # Prior to this issue being fixed, breakpoints with the same id | ||
| # would be created or updated in the default runspace. | ||
| $host.Runspace.Debugger.GetBreakpoints() | Should -BeNullOrEmpty |
Member
There was a problem hiding this comment.
test cases should be independent.
Contributor
Author
There was a problem hiding this comment.
@TravisEz13 A question about this for my own knowledge: by independent do you mean that the specific test for that issue should be in a different Describe or Context invocation? Or do you mean that the comments shouldn't be there, because they infer a dependency between that test and the issue it resolves?
|
Hello @TravisEz13! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Sep 14, 2019
…roneously replicated to the host runspace debugger (PowerShell#10503) * fix PowerShell#10167 * Update test/powershell/SDK/Breakpoint.Tests.ps1 Co-Authored-By: Ilya <[email protected]>
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #10167.
Prior to this fix, if you created, modified, or removed a breakpoint in a nested debugger or inside of a job debugger, whatever change you made would be applied to the breakpoint with the corresponding breakpoint ID in the host runspace debugger. This fix removes the event handler that was causing breakpoint changes to be erroneously replicated to the host runspace debugger.
PR Context
See discussion with @PaulHigin in #10167.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.