Skip to content

Fix for issue #7787 to allow not specifying PowerShellHome when running Install-PowerShellRemoting.ps1#10526

Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom
Orca88:patch-1
Sep 16, 2019
Merged

Fix for issue #7787 to allow not specifying PowerShellHome when running Install-PowerShellRemoting.ps1#10526
TravisEz13 merged 1 commit intoPowerShell:masterfrom
Orca88:patch-1

Conversation

@Orca88
Copy link
Copy Markdown
Contributor

@Orca88 Orca88 commented Sep 12, 2019

When PowerShellHome is not specified as a runtime parameter to Install-PowerShellRemoting.ps1, the check '-ne $null' is actually an empty string. Properly checking with [String]::IsNullOrEmpty() solves the problem.

PR Summary

Fix #7787

When PowerShellHome is not specified as a runtime parameter to Install-PowerShellRemoting.ps1, the check '-ne $null' is actually an empty string. Properly checking with [String]::IsNullOrEmpty() solves the problem.

PR Context

Restore expected behavior to match documentation of PowerShell Core installation.

PR Checklist

When PowerShellHome is not specified as a runtime parameter to Install-PowerShellRemoting.ps1, the check '-ne $null' is actually an empty string.  Properly checking with [String]::IsNullOrEmpty() solves the problem.
@Orca88 Orca88 changed the title Fix for issue #7787 Fix for issue #7787 to allow not specifying PowerShellHome when running Install-PowerShellRemoting.ps1 Sep 12, 2019
@iSazonov iSazonov requested a review from TravisEz13 September 13, 2019 09:17
@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Sep 13, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.5 milestone Sep 13, 2019
@TravisEz13 TravisEz13 merged commit fc0e3bc into PowerShell:master Sep 16, 2019
@iSazonov
Copy link
Copy Markdown
Collaborator

@Orca88 Thanks for your contribution!

@ghost
Copy link
Copy Markdown

ghost commented Oct 23, 2019

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install-PowerShellRemoting.ps1 fails when run without specifying -PowerShellHome in PowerShell 6.1 GA

4 participants