Add -Delimiter to ConvertFrom-StringData#10665
Merged
anmenaga merged 10 commits intoPowerShell:masterfrom Oct 11, 2019
Merged
Conversation
iSazonov
reviewed
Oct 1, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/ConvertFrom-StringData.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Utility/commands/utility/ConvertFrom-StringData.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Utility/commands/utility/ConvertFrom-StringData.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Utility/commands/utility/ConvertFrom-StringData.cs
Show resolved
Hide resolved
iSazonov
reviewed
Oct 2, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-StringData.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-StringData.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-StringData.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-StringData.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-StringData.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-StringData.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-StringData.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
reviewed
Oct 2, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-StringData.Tests.ps1
Outdated
Show resolved
Hide resolved
8 tasks
iSazonov
approved these changes
Oct 9, 2019
Collaborator
iSazonov
left a comment
There was a problem hiding this comment.
LGTM with two style comments.
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-StringData.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-StringData.Tests.ps1
Outdated
Show resolved
Hide resolved
|
CI passed on rebuild. |
anmenaga
approved these changes
Oct 11, 2019
Collaborator
|
Nice work @steviecoaster! 💖 |
Collaborator
|
@steviecoaster Thanks for your contribution! |
|
🎉 Handy links: |
Collaborator
|
@chuanjiao10 Please open new issue with your feedback. |
kilasuit
pushed a commit
to kilasuit/PowerShell
that referenced
this pull request
Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adds the ability to specify a delimiter to the ConvertFrom-StringData cmdlet
PR Context
ConvertFrom-StringData is powerful, but not very discoverable. This addition eases usability of the cmdlet to work with many string formats easily.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.