Skip to content

Fix stringdata test to correctly validate keys of hashtables#10810

Merged
iSazonov merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:stringdata-test
Oct 23, 2019
Merged

Fix stringdata test to correctly validate keys of hashtables#10810
iSazonov merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:stringdata-test

Conversation

@SteveL-MSFT
Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT commented Oct 16, 2019

PR Summary

The previous test wasn't correctly validating the keys in the hashtable match expected and actual. Fix is to update the test cases so the expected hashtable has the right key names and remove the unnecessary foreach loop (since we know the hashtable only has one entry) and verify the key and the value.

PR Context

PR Checklist

@iSazonov
Copy link
Copy Markdown
Collaborator

@SteveL-MSFT Please rebase to pass CI-Windows.

@iSazonov iSazonov added the WG-Quality-Test issues in a test or in test infrastructure label Oct 23, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.5 milestone Oct 23, 2019
@iSazonov iSazonov added CL-Test Indicates that a PR should be marked as a test change in the Change Log and removed WG-Quality-Test issues in a test or in test infrastructure labels Oct 23, 2019
@iSazonov iSazonov merged commit 90fb1ea into PowerShell:master Oct 23, 2019
kilasuit pushed a commit to kilasuit/PowerShell that referenced this pull request Nov 9, 2019
@ghost
Copy link
Copy Markdown

ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@SteveL-MSFT SteveL-MSFT deleted the stringdata-test branch June 6, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants