Change TabExpansion2 to not require -CursorColumn and treat as $InputScript.Length#10849
Merged
2 commits merged intoPowerShell:masterfrom Oct 30, 2019
Merged
Change TabExpansion2 to not require -CursorColumn and treat as $InputScript.Length#108492 commits merged intoPowerShell:masterfrom
-CursorColumn and treat as $InputScript.Length#108492 commits merged intoPowerShell:masterfrom
Conversation
…t as `$InputScript.Length`
rjmholt
approved these changes
Oct 20, 2019
lzybkr
reviewed
Oct 23, 2019
-CursorColumn and treat as $InputScript.Length-CursorColumn and treat as $InputScript.Length
rjmholt
reviewed
Oct 30, 2019
| param($path, $parameter, $expected) | ||
| $script = "new-item wsman:\$path $parameter" | ||
| $res = TabExpansion2 -inputScript $script -cursorColumn $script.Length | ||
| $res = TabExpansion2 -inputScript $script |
Collaborator
There was a problem hiding this comment.
Do we still have a test where the parameter is used? Ideally the number of cases we test monotonically increases
Member
Author
There was a problem hiding this comment.
@rjmholt the rest of this script uses the parameter
daxian-dbw
approved these changes
Oct 30, 2019
|
Hello @daxian-dbw! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Testing tab completion and using
TabExpansion2is annoying as most of the time you have the-CursorColumnparameter set as$inputScript.Length. This change removes-CursorColumnas a mandatory parameter and if not provided assumes it is$InputScript.Length.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.