Update AppX Manifest and Packaging module to conform to MS Store requirements#10878
Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom Oct 24, 2019
Merged
Update AppX Manifest and Packaging module to conform to MS Store requirements#10878TravisEz13 merged 2 commits intoPowerShell:masterfrom
TravisEz13 merged 2 commits intoPowerShell:masterfrom
Conversation
a99b7ab to
6fe18b1
Compare
PoshChan
reviewed
Oct 24, 2019
TravisEz13
approved these changes
Oct 24, 2019
Member
|
@PoshChan Please remind me in 1 hour |
Collaborator
|
@TravisEz13, this is the reminder you requested 1 hour ago |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Remove version from product name, it's just
PowerShellorPowerShellPreview(dash is not acceptable). Display name isPowerShellorPowerShell Preview. The architecture is needed in the manifest so that we can bundle the x64, arm, and arm64 msix into a single msixbundle. Update msix function and yaml to pass runtime so that architecture is filled in correctly.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.