Skip to content

Cleanup: use the built-in type alias#10882

Merged
iSazonov merged 15 commits intoPowerShell:masterfrom
iSazonov:cleanup-style-types-1
Nov 6, 2019
Merged

Cleanup: use the built-in type alias#10882
iSazonov merged 15 commits intoPowerShell:masterfrom
iSazonov:cleanup-style-types-1

Conversation

@iSazonov
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov commented Oct 24, 2019

PR Summary

Replace types with the built-in type aliases.

PR Context

Fix some CodeFactor issues.

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 24, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.6 milestone Oct 24, 2019
@iSazonov iSazonov self-assigned this Oct 24, 2019
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed 46/91 files

@TravisEz13
Copy link
Copy Markdown
Member

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Copy Markdown
Collaborator

@TravisEz13, this is the reminder you requested 1 hour ago

Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

87/91

@TravisEz13
Copy link
Copy Markdown
Member

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Nov 4, 2019

@TravisEz13, this is the reminder you requested 1 hour ago

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 4, 2019
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 5, 2019
@iSazonov iSazonov merged commit d58a82a into PowerShell:master Nov 6, 2019
@iSazonov iSazonov deleted the cleanup-style-types-1 branch November 6, 2019 03:47
@iSazonov
Copy link
Copy Markdown
Collaborator Author

iSazonov commented Nov 6, 2019

@TravisEz13 Thanks for the review!

@ghost
Copy link
Copy Markdown

ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze
Copy link
Copy Markdown
Contributor

Contributes to #25922.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants