Skip to content

Fix to Select-String emphasis and Import-DscResource in CHANGELOG.md#10890

Merged
anmenaga merged 2 commits intoPowerShell:masterfrom
joeyaiello:ChangelogFix
Oct 29, 2019
Merged

Fix to Select-String emphasis and Import-DscResource in CHANGELOG.md#10890
anmenaga merged 2 commits intoPowerShell:masterfrom
joeyaiello:ChangelogFix

Conversation

@joeyaiello
Copy link
Copy Markdown
Contributor

@joeyaiello joeyaiello commented Oct 25, 2019

PR Summary

Two changelog tweaks:

  • one to fix an incorrect line about Select-String in 7.0-preview.5
  • one to reword a confusing sentence about Import-DscResource

PR Context

The changelog incorrectly stated that Select-String got an -Emphasis parameter, when in fact emphasis is default and a -NoEmphasis param was added.

Also, @SteveL-MSFT had been pinged about a confusing line about Import-DscResource, so I went ahead and reworded it as well.

PR Checklist

@joeyaiello
Copy link
Copy Markdown
Contributor Author

Also, I'm happy to make the direct edit in the tag after this is approved and merged, so we don't have to retag anything.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 25, 2019
Co-Authored-By: Steve Lee <[email protected]>
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 29, 2019
@anmenaga anmenaga added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Oct 29, 2019
@anmenaga anmenaga merged commit 7f01d1c into PowerShell:master Oct 29, 2019
@TravisEz13
Copy link
Copy Markdown
Member

Updated the preview.5 release notes.

@ghost
Copy link
Copy Markdown

ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants