Skip to content

Install-Powershell.ps1: Add parameter to use MSI installation#10921

Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom
MJECloud:master
Oct 30, 2019
Merged

Install-Powershell.ps1: Add parameter to use MSI installation#10921
TravisEz13 merged 1 commit intoPowerShell:masterfrom
MJECloud:master

Conversation

@MJECloud
Copy link
Copy Markdown
Contributor

PR Summary

Added Parameter -AddExplorerContextMenu and -EnablePSRemoting to use MSI properties.
Documented here

PR Context

PR Checklist

@TravisEz13
Copy link
Copy Markdown
Member

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Copy Markdown
Collaborator

@TravisEz13, this is the reminder you requested 1 hour ago

@TravisEz13
Copy link
Copy Markdown
Member

looks like this needs to be rebased to get the tests to pass.

@MJECloud
Copy link
Copy Markdown
Contributor Author

Rebased to resolve the conflicts

@TravisEz13
Copy link
Copy Markdown
Member

The rebase is bad... I'll try to fix it. Please don't do any changes to your branch.

@TravisEz13
Copy link
Copy Markdown
Member

I fixed the rebase. If you make changes, be sure to fetch the new history in your branch first.

@TravisEz13
Copy link
Copy Markdown
Member

@PoshChan Please remind me in 1 hour

@MJECloud
Copy link
Copy Markdown
Contributor Author

Oh i'm sorry for messing it up.
Thanks for fixing, will remember it next time :)

@TravisEz13
Copy link
Copy Markdown
Member

Here is the command I ran, after I reset your branch to before your merge.
~/git/powershell> git rebase master-upstream pr/MJECloud/10921

@TravisEz13 TravisEz13 changed the title Install-Powershell.ps1: Add parameter to use MSI installation properties Install-Powershell.ps1: Add parameter to use MSI installation Oct 30, 2019
@TravisEz13 TravisEz13 merged commit 96e2a2e into PowerShell:master Oct 30, 2019
@PoshChan
Copy link
Copy Markdown
Collaborator

@TravisEz13, this is the reminder you requested 1 hour ago

@PaulHigin PaulHigin added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Nov 19, 2019
@PaulHigin PaulHigin added this to the 7.0.0-preview.6 milestone Nov 19, 2019
@ghost
Copy link
Copy Markdown

ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants