Skip to content

Update tests to accurately describe test actions. #10928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Oct 30, 2019
Merged

Update tests to accurately describe test actions. #10928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/powershell/Modules/Microsoft.PowerShell.Management/New-Item.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Describe "New-Item" -Tags "CI" {
Test-Path $FullyQualifiedFile | Should -BeTrue
}

It "Should create a file with sample text inside the file using the Value switch" {
It "Should create a file with sample text inside the file using the Value parameter" {
$expected = "This is test string"
New-Item -Name $testfile -Path $tmpDirectory -ItemType file -Value $expected

Expand All @@ -89,15 +89,15 @@ Describe "New-Item" -Tags "CI" {
Get-Content $FullyQualifiedFile | Should -Be $expected
}

It "Should not create a file when the Name switch is not used and only a directory specified" {
It "Should not create a file when the Name parameter is not used and only a directory specified" {
#errorAction used because permissions issue in Windows
New-Item -Path $tmpDirectory -ItemType file -ErrorAction SilentlyContinue

Test-Path $FullyQualifiedFile | Should -BeFalse

}

It "Should create a file when the Name switch is not used but a fully qualified path is specified" {
It "Should create a file when the Name parameter is not used but a fully qualified path is specified" {
New-Item -Path $FullyQualifiedFile -ItemType file

Test-Path $FullyQualifiedFile | Should -BeTrue
Expand Down
2 changes: 1 addition & 1 deletion test/powershell/Modules/Microsoft.PowerShell.Management/Set-Location.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Describe "Set-Location" -Tags "CI" {
$(Get-Location).Path | Should -BeExactly $startDirectory.Path
}

It "Should be able to use the Path switch" {
It "Should be able to use the Path parameter" {
{ Set-Location -Path $target } | Should -Not -Throw
}

Expand Down