Fix piping more than one CommandInfo to Get-Command#10929
Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom Nov 7, 2019
Merged
Fix piping more than one CommandInfo to Get-Command#10929adityapatwardhan merged 2 commits intoPowerShell:masterfrom
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
Conversation
PoshChan
reviewed
Oct 29, 2019
Member
Author
|
@PoshChan please retry linux |
Collaborator
|
@SteveL-MSFT, successfully started retry of |
iSazonov
reviewed
Oct 29, 2019
test/powershell/Modules/Microsoft.PowerShell.Core/Get-Command.Tests.ps1
Outdated
Show resolved
Hide resolved
…Tests.ps1 Co-Authored-By: Ilya <[email protected]>
iSazonov
approved these changes
Oct 29, 2019
rjmholt
approved these changes
Oct 29, 2019
adityapatwardhan
approved these changes
Nov 7, 2019
Contributor
|
Unfortunately, this PR didn't fix all problems, because the following tests fail: |
Member
Author
|
@mklement0 those are different issues not related to piping to Get-Command, please open a new issue for them |
Contributor
|
@SteveL-MSFT: These tests do pipe to |
Contributor
|
If it helps with getting this resolved, please see #11017 |
Member
Author
|
@mklement0 my mistake, I only saw the left side of the pipe. In anycase, the root cause is something different. |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Piping multiple CommandInfo to
Get-Commandonly returns the first result. This is because during discovery of the command it internally builds a cache of commands it has already seen. On the second (or more) timesProcessRecord()is called, that cache is already filled with some results. If the requested CommandInfo (which binds to-Verband-Noun) happens to be in that cache, then the cmdlet considers that a duplicate and doesn't return that result. The fix in this case is to clear the cache at the start ofProcessRecord()to treat each search as independent.PR Context
Fix #10851
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.