Fix GetCorrectCasedPath() to first check if any system file entries is returned before calling First()#10930
Merged
anmenaga merged 2 commits intoPowerShell:masterfrom Oct 31, 2019
Merged
Conversation
Collaborator
|
I can not repo on WSL1. Is the issue on WSL2? |
anmenaga
reviewed
Oct 29, 2019
anmenaga
left a comment
There was a problem hiding this comment.
WSL== Windows Subsystem for Linux ? it would be good to mention this in PR description.
src/System.Management.Automation/namespaces/FileSystemProvider.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/namespaces/FileSystemProvider.cs
Outdated
Show resolved
Hide resolved
anmenaga
approved these changes
Oct 30, 2019
anmenaga
approved these changes
Oct 31, 2019
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
On WSL, if you have a folder in /mnt/c/Users/steve/Blah and try:
test-path /mnt/c/Users/steve/blah -pathtype containeryou get an error because.First()is being called on an empty string array. Fix is to check that the returned array contains something. Otherwise, just return the given path as some file system issue prevents correcting the casing. This issue seems to only repro on WSL (Windows Subsystem on Linux)PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.