Add back Get-Counter cmdlet for Windows#10933
Merged
TravisEz13 merged 8 commits intoPowerShell:masterfrom Nov 6, 2019
Merged
Conversation
10 tasks
Member
Author
|
@sdwheeler new fwlink for Get-Counter? |
PoshChan
reviewed
Oct 29, 2019
Collaborator
|
@SteveL-MSFT https://go.microsoft.com/fwlink/?linkid=2109647
|
iSazonov
reviewed
Oct 30, 2019
Collaborator
iSazonov
left a comment
There was a problem hiding this comment.
I found https://github.com/microsoft/Tx. It seems work with blg.
Member
Author
|
@iSazonov nice find, seems that Tx is using a different set of APIs to read the log, not sure if there is a different public api to write the binary log. I suggest we defer this for now. |
iSazonov
approved these changes
Oct 30, 2019
Collaborator
Maybe open a tracking issue if you plan to investigate this? |
Member
Author
16 tasks
Member
|
@SteveL-MSFT Can you run a coordinated package build and send me a Direct Message with the build information? Let's verify this doesn't cause any new compliance issues. |
TravisEz13
requested changes
Nov 5, 2019
src/Microsoft.PowerShell.Commands.Diagnostics/Microsoft.PowerShell.Commands.Diagnostics.csproj
Show resolved
Hide resolved
PoshChan
reviewed
Nov 5, 2019
TravisEz13
approved these changes
Nov 6, 2019
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Reviewed the APIs being used.
Get-Countercan work with just public APIs published in pdh.h.Import-CounterandExport-Counterrely on undocumented APIs so those are removed. The PDH apis are really old so I don't believe there's any chance to get those APIs or the binary log format documented so removed that code.Get-Counter -ListSethas Description property as empty because it isn't supported by PDH apis.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.Get-Countercmdlet for PS7 MicrosoftDocs/PowerShell-Docs#5020