Add Culture parameter to Select-String cmdlet#10943
Merged
adityapatwardhan merged 6 commits intoPowerShell:masterfrom Nov 16, 2019
Merged
Add Culture parameter to Select-String cmdlet#10943adityapatwardhan merged 6 commits intoPowerShell:masterfrom
adityapatwardhan merged 6 commits intoPowerShell:masterfrom
Conversation
PoshChan
reviewed
Oct 30, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/MatchString.cs
Show resolved
Hide resolved
SteveL-MSFT
requested changes
Oct 30, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/Select-String.Tests.ps1
Outdated
Show resolved
Hide resolved
SteveL-MSFT
approved these changes
Oct 31, 2019
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Please address Codacy issues
Collaborator
Author
I fix one but second impossible (interface implementation). |
30524de to
aa9cc09
Compare
PaulHigin
suggested changes
Nov 4, 2019
| @@ -1734,7 +1841,7 @@ private bool DoMatchWorker(string operandString, MatchInfo matchInfo, out MatchI | |||
| { | |||
Contributor
There was a problem hiding this comment.
This old 'StringComparison compareOption = ...' code can be removed.
adityapatwardhan
approved these changes
Nov 12, 2019
Member
|
@iSazonov Can you respond to comment from @PaulHigin |
10 tasks
Collaborator
Author
|
@adityapatwardhan Paul's comment addressed. Doc issue was filled. |
PaulHigin
approved these changes
Nov 13, 2019
TravisEz13
reviewed
Nov 14, 2019
| /// <summary> | ||
| /// Get list of valid culture names for ValidateSet attribute. | ||
| /// </summary> | ||
| public class ValidateMatchStringCultureNamesGenerator : IValidateSetValuesGenerator |
Collaborator
Author
There was a problem hiding this comment.
It must be public:
PowerShell/src/System.Management.Automation/engine/Attributes.cs
Lines 1715 to 1723 in fe40fbf
Member
|
@iSazonov Please respond the comment from @TravisEz13 |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #8180
Add new
Cultureparameter to Select-String cmdlet.PR Context
Implement PowerShell/PowerShell-RFC#167 for Select-String cmdlet.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.