Skip to content

Support $null for convertto-json#10947

Merged
iSazonov merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:null-json
Nov 1, 2019
Merged

Support $null for convertto-json#10947
iSazonov merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:null-json

Conversation

@SteveL-MSFT
Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT commented Oct 30, 2019

PR Summary

ConvertTo-Json doesn't allow $null to be passed in even though it can be valid resulting json. Fix is to remove the check that the input is not null. NewtonSoft.Json handles it just fine.

PR Context

Fix #10942

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 31, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.6 milestone Oct 31, 2019
@iSazonov iSazonov merged commit 70ab772 into PowerShell:master Nov 1, 2019
@iSazonov iSazonov changed the title support $null for convertto-json Support $null for convertto-json Nov 1, 2019
@ghost
Copy link
Copy Markdown

ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

@SteveL-MSFT SteveL-MSFT deleted the null-json branch June 6, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConvertTo-Json doesn't serialize $null

2 participants