Make ConvertTo-Json treat [AutomationNull]::Value and [NullString]::Value as $null#10957
Merged
anmenaga merged 3 commits intoPowerShell:masterfrom Nov 5, 2019
Merged
Make ConvertTo-Json treat [AutomationNull]::Value and [NullString]::Value as $null#10957anmenaga merged 3 commits intoPowerShell:masterfrom
ConvertTo-Json treat [AutomationNull]::Value and [NullString]::Value as $null#10957anmenaga merged 3 commits intoPowerShell:masterfrom
Conversation
PoshChan
reviewed
Oct 31, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/JsonObject.cs
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Oct 31, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/JsonObject.cs
Outdated
Show resolved
Hide resolved
anmenaga
reviewed
Oct 31, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Json.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Json.Tests.ps1
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Oct 31, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/JsonObject.cs
Outdated
Show resolved
Hide resolved
anmenaga
approved these changes
Nov 1, 2019
Member
Author
|
Rebased to resolve conflicts. |
PoshChan
reviewed
Nov 4, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/JsonObject.cs
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Nov 4, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/JsonObject.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@PoshChan Please retry static |
Member
Author
|
@PoshChan Please retry linux |
Collaborator
|
@daxian-dbw, successfully started retry of |
Collaborator
|
@daxian-dbw, successfully started retry of |
PoshChan
reviewed
Nov 5, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/JsonObject.cs
Outdated
Show resolved
Hide resolved
SteveL-MSFT
approved these changes
Nov 5, 2019
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #9231
Make
ConvertTo-Jsontreat[AutomationNull]::Valueand[NullString]::Valueas$nullThis is a breaking change given the fact that
[AutomationNull]::Valueand[NullString]::Valueare deserailized into an empty object{}today and will benullafter this change.However, it's hard to believe anyone is depending on the current wrong behavior.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.