Fix crash if command sent to pwsh is just whitespace#10977
Merged
anmenaga merged 2 commits intoPowerShell:masterfrom Nov 4, 2019
Merged
Fix crash if command sent to pwsh is just whitespace#10977anmenaga merged 2 commits intoPowerShell:masterfrom
anmenaga merged 2 commits intoPowerShell:masterfrom
Conversation
rjmholt
reviewed
Nov 2, 2019
src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs
Outdated
Show resolved
Hide resolved
iSazonov
approved these changes
Nov 3, 2019
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
In the early parsing code, a null switchkey can be returned. This isn't expected in later code resulting in an unhandled exception. Fix is to check if switchkey is null before additoinal processing. In this case, just whitespace is sent to PowerShell whereas an empty string returns an error.
PR Context
Fix #10975
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.