Fix style issues#10998
Merged
adityapatwardhan merged 16 commits intoPowerShell:masterfrom Nov 7, 2019
Merged
Conversation
PoshChan
reviewed
Nov 6, 2019
| @@ -19,7 +19,7 @@ internal static class Clipboard | |||
| private static string StartProcess( | |||
Collaborator
There was a problem hiding this comment.
@iSazonov, your last commit had 1 failures in PowerShell-CI-windows
Enter-PSHostProcess tests.By CustomPipeName.Can enter, exit, and re-enter using CustomPipeName
Expected $true, because The script was able to re-enter another process and grab the pipe of '4fzpekvk.ydv'., but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\Enter-PSHostProcess.Tests.ps1: line 170
170: Should -BeTrue -Because "The script was able to re-enter another process and grab the pipe of '$pipeName'."
SteveL-MSFT
requested changes
Nov 6, 2019
| { | ||
| /// <summary> | ||
| /// Construct a new chainable AST with the given extent. | ||
| /// Initializes a new instance of the new chainable AST with the given extent. |
| { | ||
| /// <summary> | ||
| /// Create a new statement chain AST from two statements and an operator. | ||
| /// Initializes a new instance of the new statement chain AST from two statements and an operator. |
SteveL-MSFT
approved these changes
Nov 7, 2019
Member
|
@TravisEz13 it's easier to review by commit than by file since the changes are similar per commit |
adityapatwardhan
approved these changes
Nov 7, 2019
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix style issues that appeared in the last month.
Easy review commit by commit.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.