Handle exception if enumerating files fails when rebuilding path to have correct casing#11014
Merged
anmenaga merged 2 commits intoPowerShell:masterfrom Nov 12, 2019
Merged
Conversation
…ave correct casing
PoshChan
reviewed
Nov 7, 2019
Member
Author
|
@PoshChan please retry static |
Collaborator
|
@SteveL-MSFT, successfully started retry of |
iSazonov
reviewed
Nov 8, 2019
test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
Outdated
Show resolved
Hide resolved
…stem.Tests.ps1 Co-Authored-By: Ilya <[email protected]>
iSazonov
approved these changes
Nov 8, 2019
anmenaga
approved these changes
Nov 12, 2019
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
In the code to reconstruct a path with correct casing, it has to go through each segment and use enumeration to get the correct case. On some directories the user may not have permission to enumerate although they can still read a file/folder within that directory. Fix is if there is an exception during enumeration, fail gracefully by just returning back the original path.
PR Context
Fix #11013
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.