Skip to content

Correct 'review-for-comments' in Governance.md#11035

Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom
MarvTheRobot:patch-1
May 28, 2020
Merged

Correct 'review-for-comments' in Governance.md#11035
TravisEz13 merged 1 commit intoPowerShell:masterfrom
MarvTheRobot:patch-1

Conversation

@MarvTheRobot
Copy link
Copy Markdown
Contributor

@MarvTheRobot MarvTheRobot commented Nov 11, 2019

PR Summary

Minor update due to typo.
RFC should be 'request for comments'

This PR addresses issue #11034

PR Context

I was reading the documentation around the RFC process so that I can 'borrow' it for my own project.

PR Checklist

@MarvTheRobot MarvTheRobot changed the title Correct 'review-for-comments' in docs/community/Governance.md, #11034 Correct 'review-for-comments' in docs/community/Governance.md, addresses #11034 Nov 11, 2019
@TravisEz13
Copy link
Copy Markdown
Member

@PoshChan Please remind me in 1 hour.

@PoshChan
Copy link
Copy Markdown
Collaborator

@TravisEz13, this is the reminder you requested 1 hour. ago

@ghost ghost added the Review - Needed The PR is being reviewed label May 27, 2020
@ghost
Copy link
Copy Markdown

ghost commented May 27, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

@TravisEz13 TravisEz13 added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label May 28, 2020
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.4 milestone May 28, 2020
@TravisEz13 TravisEz13 changed the title Correct 'review-for-comments' in docs/community/Governance.md, addresses #11034 Correct 'review-for-comments' in Governance.md May 28, 2020
@TravisEz13 TravisEz13 merged commit 8a2d170 into PowerShell:master May 28, 2020
@TravisEz13 TravisEz13 removed the Review - Needed The PR is being reviewed label May 28, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants