Fix Start-Job working directory path with trailing back slash#11041
Merged
adityapatwardhan merged 4 commits intoPowerShell:masterfrom Nov 16, 2019
PaulHigin:fix-startjob-wd-withtrailingbackslash
Merged
Fix Start-Job working directory path with trailing back slash#11041adityapatwardhan merged 4 commits intoPowerShell:masterfrom PaulHigin:fix-startjob-wd-withtrailingbackslash
adityapatwardhan merged 4 commits intoPowerShell:masterfrom
PaulHigin:fix-startjob-wd-withtrailingbackslash
Conversation
SteveL-MSFT
requested changes
Nov 12, 2019
iSazonov
reviewed
Nov 12, 2019
src/System.Management.Automation/engine/hostifaces/PowerShellProcessInstance.cs
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Nov 13, 2019
src/System.Management.Automation/engine/hostifaces/PowerShellProcessInstance.cs
Show resolved
Hide resolved
PoshChan
reviewed
Nov 13, 2019
src/System.Management.Automation/engine/hostifaces/PowerShellProcessInstance.cs
Show resolved
Hide resolved
iSazonov
approved these changes
Nov 14, 2019
adityapatwardhan
approved these changes
Nov 15, 2019
Member
|
@SteveL-MSFT - Please update your review. |
SteveL-MSFT
approved these changes
Nov 15, 2019
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This fixes a bug where a working directory path with a trailing back slash causes Start-Job to fail.
PR Context
Windows command line parsing will drop any trailing back slash in the argument list. The fix is to escape all back slash characters in the Start-Job working directory path, before including it in the argument list.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.