Skip to content

Add default for SDKToUse so that solution builds in Visual Studio#11085

Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:visualstudio-build
Nov 16, 2019
Merged

Add default for SDKToUse so that solution builds in Visual Studio#11085
daxian-dbw merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:visualstudio-build

Conversation

@SteveL-MSFT
Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT commented Nov 15, 2019

PR Summary

build.psm1 was updated awhile back to conditional build with and without WindowsDesktop SDK depending on target. Since this is only defined in build.psm1, it doesn't build in VisualStudio using the solution file. Fix is to add in powershell-win-core project file to define SDKToUse to default to WindowsDesktop SDK if it isn't already defined.

PR Checklist

@daxian-dbw daxian-dbw merged commit e65d1f1 into PowerShell:master Nov 16, 2019
@bergmeister
Copy link
Copy Markdown
Contributor

bergmeister commented Nov 17, 2019

Thanks, I haven't had the time to test it yet but it is very appreciated that the team tries to keep the VS support as quite a few community members like me, Staffan and others like to use VS for some code navigation/debugging where vs-code sometimes is too simplistic or lacks some of the enhanced features of VS (despite VS being a bit more heavy)

@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Nov 18, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.6 milestone Nov 18, 2019
@SteveL-MSFT SteveL-MSFT deleted the visualstudio-build branch November 18, 2019 20:44
@ghost
Copy link
Copy Markdown

ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants