Add default for SDKToUse so that solution builds in Visual Studio#11085
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Nov 16, 2019
Merged
Add default for SDKToUse so that solution builds in Visual Studio#11085daxian-dbw merged 1 commit intoPowerShell:masterfrom
daxian-dbw merged 1 commit intoPowerShell:masterfrom
Conversation
adityapatwardhan
approved these changes
Nov 16, 2019
daxian-dbw
approved these changes
Nov 16, 2019
Contributor
|
Thanks, I haven't had the time to test it yet but it is very appreciated that the team tries to keep the VS support as quite a few community members like me, Staffan and others like to use VS for some code navigation/debugging where vs-code sometimes is too simplistic or lacks some of the enhanced features of VS (despite VS being a bit more heavy) |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
build.psm1was updated awhile back to conditional build with and without WindowsDesktop SDK depending on target. Since this is only defined in build.psm1, it doesn't build in VisualStudio using the solution file. Fix is to add in powershell-win-core project file to define SDKToUse to default to WindowsDesktop SDK if it isn't already defined.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.