Make update notification support LTS and default channels#11132
Merged
adityapatwardhan merged 4 commits intoPowerShell:masterfrom Dec 10, 2019
Merged
Make update notification support LTS and default channels#11132adityapatwardhan merged 4 commits intoPowerShell:masterfrom
adityapatwardhan merged 4 commits intoPowerShell:masterfrom
Conversation
iSazonov
reviewed
Nov 20, 2019
src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Nov 21, 2019
Member
Author
|
@PoshChan please retry windows |
Collaborator
|
@daxian-dbw, successfully started retry of |
iSazonov
approved these changes
Nov 22, 2019
src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs
Outdated
Show resolved
Hide resolved
rjmholt
reviewed
Nov 25, 2019
src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs
Outdated
Show resolved
Hide resolved
rjmholt
approved these changes
Nov 26, 2019
PoshChan
reviewed
Dec 2, 2019
iSazonov
approved these changes
Dec 3, 2019
Member
Author
|
@PoshChan please retry windows |
Collaborator
|
@daxian-dbw, successfully started retry of |
PoshChan
reviewed
Dec 3, 2019
Member
Author
|
@PoshChan please retry windows |
Collaborator
|
@daxian-dbw, successfully started retry of |
PoshChan
reviewed
Dec 3, 2019
PoshChan
reviewed
Dec 3, 2019
Member
Author
|
@adityapatwardhan I think this PR is ready to be merged. |
|
🎉 Handy links: |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update the feature to support the notification type that can be configured using the environment variable
POWERSHELL_UPDATECHECK.This is to address the feedback from powershell committee in the RFC review: PowerShell/PowerShell-RFC#162 (comment), quoted below:
POWERSHELL_UPDATECHECKaccepts 3 values:Off,Default, andLTS(case-insensitive), and the behavior is as follows:Off: turn off the udpate notification.Default: give you the default behaviorsLTS: both preview and GA version 'pwsh' checks for the new LTS version only.For a specific version of pwsh and a specific notification type, only one update check task, at most, will run to complete per a day. Other tasks should be able to detect "a check is in progress" or "the check has been done for today" and bail out early, to avoid any unnecessary network IO or CPU cycles.
Note that this is a breaking change comparing to
preview-5andpreview-6, because the environment variable name and its accepted values are changed.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.