Skip to content

Add Unblock-File for macOS#11137

Merged
TravisEz13 merged 13 commits intoPowerShell:masterfrom
TravisEz13:unblock
Dec 3, 2019
Merged

Add Unblock-File for macOS#11137
TravisEz13 merged 13 commits intoPowerShell:masterfrom
TravisEz13:unblock

Conversation

@TravisEz13
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 commented Nov 20, 2019 •
edited
Loading

PR Summary

Add Unblock-File for macOS

PR Context

Adds a viable workaround for #10874, not just for our package but for other packages.

PR Checklist

iSazonov
iSazonov reviewed Nov 21, 2019
View reviewed changes
SteveL-MSFT
SteveL-MSFT requested changes Nov 21, 2019
View reviewed changes
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Nov 21, 2019
@TravisEz13 TravisEz13 marked this pull request as ready for review November 22, 2019 21:49
@TravisEz13 TravisEz13 added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 22, 2019
@TravisEz13 TravisEz13 added this to the rc.1-consider milestone Nov 22, 2019
@TravisEz13 TravisEz13 mentioned this pull request Nov 22, 2019
Closed
10 tasks
adityapatwardhan
adityapatwardhan requested changes Dec 2, 2019
View reviewed changes
src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs Outdated
{
string errorMessage = UnblockFileStrings.LinuxNotSupported;
Exception e = new NotImplementedException(errorMessage);
ThrowTerminatingError(new ErrorRecord(e, "LinuxNotSupported", ErrorCategory.NotImplemented, null));
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use named parameters.

src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs Outdated
{
if(IsBlocked(path))
{
UInt32 result = RemoveXattr(path,MacBlockAttribute,RemovexattrFollowSymLink);
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: spaces after ,

src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs Outdated
{
string errorMessage = string.Format(CultureInfo.CurrentUICulture, UnblockFileStrings.UnblockError, path);
Exception e = new InvalidOperationException(errorMessage);
WriteError(new ErrorRecord(e, "UnblockError", ErrorCategory.InvalidResult,path));
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: spaces after ,

src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs
if(result != 0)
{
string errorMessage = string.Format(CultureInfo.CurrentUICulture, UnblockFileStrings.UnblockError, path);
Exception e = new InvalidOperationException(errorMessage);
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should be System.PlatformNotSupportedException

Copy link
Copy Markdown
Member Author

@TravisEz13 TravisEz13 Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely not, we are on a supported platform here.

Copy link
Copy Markdown
Member Author

@TravisEz13 TravisEz13 Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you meant line 142... changed it there.

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 2, 2019
@TravisEz13 TravisEz13 merged commit 3cdab0d into PowerShell:master Dec 3, 2019
@TravisEz13 TravisEz13 deleted the unblock branch December 3, 2019 01:51
TravisEz13 added a commit that referenced this pull request Dec 4, 2019
@TravisEz13
Add Unblock-File for macOS (#11137)
9bb1504
@TravisEz13 TravisEz13 modified the milestones: rc.1-approved, 7.0.0-rc.1 Dec 4, 2019
@ghost
Copy link
Copy Markdown

ghost commented Dec 16, 2019

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

+1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.0.0-rc.1

Development

Successfully merging this pull request may close these issues.

5 participants

@TravisEz13 @SteveL-MSFT @adityapatwardhan @iSazonov @PoshChan