Fix detection of $PSHOME in front of $env:PATH#11141
Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom Nov 23, 2019
Merged
Fix detection of $PSHOME in front of $env:PATH#11141TravisEz13 merged 2 commits intoPowerShell:masterfrom
TravisEz13 merged 2 commits intoPowerShell:masterfrom
Conversation
PoshChan
reviewed
Nov 21, 2019
PoshChan
reviewed
Nov 21, 2019
daxian-dbw
approved these changes
Nov 22, 2019
TravisEz13
approved these changes
Nov 23, 2019
TravisEz13
pushed a commit
that referenced
this pull request
Dec 4, 2019
|
🎉 Handy links: |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Previous code was incorrectly detecting if $PSHOME was in front using
.Contains()since a preview would have the path "$PSHOME\preview" in front. Since this affects startup, we don't want to do a bunch of string manipulation with Split() so to cover the most common case we just check if the start of$env:PATHcontains$PSHOMEwith the path separator and if not add to front. Two scenarios that aren't covered:$PSHOMEis somewhere else in$env:PATHit will be duplicated. This is unlikely and will just have a small perf impact searching$env:PATH.$env:PATHonly contains$PSHOME(without the path separator), then it'll also be duplicated, but this is also unlikely with minor impact.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.