Fix apartment thread state check on non-Windows platforms.#11301
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Dec 10, 2019
PaulHigin:fix-non-windows-apartmentstate-check
Merged
Fix apartment thread state check on non-Windows platforms.#11301daxian-dbw merged 1 commit intoPowerShell:masterfrom PaulHigin:fix-non-windows-apartmentstate-check
daxian-dbw merged 1 commit intoPowerShell:masterfrom
PaulHigin:fix-non-windows-apartmentstate-check
Conversation
SteveL-MSFT
reviewed
Dec 9, 2019
SteveL-MSFT
approved these changes
Dec 9, 2019
TravisEz13
pushed a commit
that referenced
this pull request
Dec 11, 2019
|
🎉 Handy links: |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR removes the apartment thread state check when invoking a script on a PowerShell object for non-Windows platforms.
PR Context
I found this while testing SSH remoting on non-Windows platforms. Entering into an interactive session on an SSH remote connection between PS6 and PS7 results in an error. The error is due to the apartment thread state check, which should not apply to UNIX platforms. This is a regression.
The fix is to simply remove the check since it is not needed for UNIX platforms.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.