Update error message if Update-Help fails for the current UICulture#11356
Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom Dec 20, 2019
Merged
Update error message if Update-Help fails for the current UICulture#11356adityapatwardhan merged 1 commit intoPowerShell:masterfrom
adityapatwardhan merged 1 commit intoPowerShell:masterfrom
Conversation
PoshChan
reviewed
Dec 16, 2019
Member
Author
|
@PoshChan please retry windows |
Collaborator
|
@SteveL-MSFT, successfully started retry of |
Collaborator
We could add new config/gpo parameter UseHelpFallbackCulture so that users can explicitly say that they want download help files in en-US or another culture. |
Member
Author
adityapatwardhan
approved these changes
Dec 20, 2019
daxian-dbw
pushed a commit
that referenced
this pull request
Jan 10, 2020
|
🎉 Handy links: |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
If the user has a UICulture other than en-US, help content is not available and does not successfully update. The user may not know how to get the en-US content. Fix is to update the error informing the user how to choose en-US content.
PR Context
Help content is currently only available as en-US. If the user has a different culture, it does not fallback to en-US which is expected due to geopolitical reasons we cannot assume it is correct to always fallback to en-US automatically.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.