Update hosting tests to use the SDK version from the build property#11368
Merged
anmenaga merged 1 commit intoPowerShell:masterfrom Dec 18, 2019
Merged
Update hosting tests to use the SDK version from the build property#11368anmenaga merged 1 commit intoPowerShell:masterfrom
anmenaga merged 1 commit intoPowerShell:masterfrom
Conversation
PoshChan
reviewed
Dec 17, 2019
PoshChan
reviewed
Dec 17, 2019
PoshChan
reviewed
Dec 17, 2019
anmenaga
approved these changes
Dec 18, 2019
daxian-dbw
pushed a commit
that referenced
this pull request
Jan 10, 2020
|
🎉 Handy links: |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The SDK tests need to use the PS Version of the release under proces. By passing it as a build property we can dynamically change the value. We get the value in the release pipeline through the release metadata json.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.