Skip to content

Fix test failing when UnixStat feature is disabled#11370

Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom
adityapatwardhan:FixUnixStatTests
Dec 20, 2019
Merged

Fix test failing when UnixStat feature is disabled#11370
adityapatwardhan merged 1 commit intoPowerShell:masterfrom
adityapatwardhan:FixUnixStatTests

Conversation

@adityapatwardhan
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan commented Dec 17, 2019 •
edited
Loading

PR Summary

Fixes #11357

PR Context

We check if the experimental feature is enabled before determining the expected value.

PR Checklist

@adityapatwardhan adityapatwardhan added this to the GA-consider milestone Dec 17, 2019
@daxian-dbw daxian-dbw closed this Dec 17, 2019
@daxian-dbw daxian-dbw reopened this Dec 17, 2019
@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Dec 17, 2019

close/open PR to re-trigger CIs.

@adityapatwardhan
Copy link
Copy Markdown
Member Author

adityapatwardhan commented Dec 17, 2019

@PoshChan please rebuild all

@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Dec 17, 2019

@adityapatwardhan, successfully started rebuild of PowerShell-CI-static-analysis, PowerShell-CI-Windows, PowerShell-CI-macOS, PowerShell-CI-Linux

PoshChan
PoshChan reviewed Dec 17, 2019
View reviewed changes
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-FormatData.Tests.ps1
@@ -15,7 +15,9 @@ Describe "Get-FormatData" -Tags "CI" {
$format.TypeNames | Should -HaveCount 2
Copy link
Copy Markdown
Collaborator

@PoshChan PoshChan Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityapatwardhan, your last commit had 1 failures in PowerShell-CI-macos
Validate Update-Help from the Web for all PowerShell modules for user scope..Validate Update-Help for module 'PackageManagement' with scope as 'False'

Expected 1, but got 0.
at <ScriptBlock>, /Users/runner/runners/2.160.1/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181:     $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count

@adityapatwardhan
Copy link
Copy Markdown
Member Author

adityapatwardhan commented Dec 17, 2019

@PoshChan please retry macos

@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Dec 17, 2019

@adityapatwardhan, successfully started retry of PowerShell-CI-macOS

@adityapatwardhan
Copy link
Copy Markdown
Member Author

adityapatwardhan commented Dec 17, 2019

@PoshChan please rebuild all

@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Dec 17, 2019

@adityapatwardhan, successfully started rebuild of PowerShell-CI-static-analysis, PowerShell-CI-Windows, PowerShell-CI-macOS, PowerShell-CI-Linux

@adityapatwardhan adityapatwardhan merged commit ed27f36 into PowerShell:master Dec 20, 2019
@adityapatwardhan adityapatwardhan deleted the FixUnixStatTests branch December 20, 2019 23:32
daxian-dbw pushed a commit that referenced this pull request Jan 10, 2020
@adityapatwardhan @daxian-dbw
Fix test failing when UnixStat feature is disabled (#11370)
94b215d
@daxian-dbw daxian-dbw modified the milestones: GA-approved, 7.0.0-rc.2 Jan 11, 2020
@daxian-dbw daxian-dbw mentioned this pull request Jan 14, 2020
Merged
14 tasks
@daxian-dbw daxian-dbw added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 15, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jan 16, 2020

🎉v7.0.0-rc.2 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 16, 2020
Closed
@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

+1 more reviewer

@PoshChan PoshChan PoshChan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

7.0.0-rc.2

Development

Successfully merging this pull request may close these issues.

Tests failing due to UnixStat feature being disabled

3 participants

@adityapatwardhan @daxian-dbw @PoshChan