Move Set-StrictMode to outer scriptblock for ErrorView#11381
Merged
iSazonov merged 2 commits intoPowerShell:masterfrom Dec 17, 2019
Merged
Move Set-StrictMode to outer scriptblock for ErrorView#11381iSazonov merged 2 commits intoPowerShell:masterfrom
iSazonov merged 2 commits intoPowerShell:masterfrom
Conversation
PoshChan
reviewed
Dec 17, 2019
...stem.Management.Automation/FormatAndOutput/DefaultFormatters/PowerShellCore_format_ps1xml.cs
Show resolved
Hide resolved
PoshChan
reviewed
Dec 17, 2019
...stem.Management.Automation/FormatAndOutput/DefaultFormatters/PowerShellCore_format_ps1xml.cs
Show resolved
Hide resolved
PoshChan
reviewed
Dec 17, 2019
...stem.Management.Automation/FormatAndOutput/DefaultFormatters/PowerShellCore_format_ps1xml.cs
Show resolved
Hide resolved
iSazonov
reviewed
Dec 17, 2019
...stem.Management.Automation/FormatAndOutput/DefaultFormatters/PowerShellCore_format_ps1xml.cs
Show resolved
Hide resolved
iSazonov
approved these changes
Dec 17, 2019
daxian-dbw
pushed a commit
that referenced
this pull request
Jan 10, 2020
|
🎉 Handy links: |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The
NormalViewcode tries to use a member that may not exist. So when using strict mode, this line fails and so nothing is returned to the user as an exception is thrown in the formatter. Fix is to move the call to turn off strict mode from the helper function to the outer script block.PR Context
Fix #11371
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.